feature/s3/manager: Suppress WriterAt which can bypass Windows optimizations. #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
changed the title
jasdel
approved these changes
Aug 5, 2022
|
It's a little confusion that title & code suggest that this commit is suppressing WriterAt, while above comment suggest suppressing WriterTo, could you please clarify which one is correct? @skmcgrail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with Go 1.19 discovered in the S3 transfer manager's windows upload and downloader buffer pools. It looks like the update to Go 1.19 changes the code path that is used by the pool because
io.NopCloserwas updated to forwardWriterToif the underlyingWriterimplemented it. Looks likes we'd made some assumptions about this behavior not being present. This PR suppresses theWriterToof the buffer pool to prevent the unexpected usage.